Skip to content

add jib example, improve dockerignores#2

Merged
nicks merged 1 commit intomasterfrom
nicks/jib
Mar 17, 2020
Merged

add jib example, improve dockerignores#2
nicks merged 1 commit intomasterfrom
nicks/jib

Conversation

@nicks
Copy link
Member

@nicks nicks commented Mar 17, 2020

Hello @nicks,

Please review the following commits I made in branch nicks/jib:

3702369 (2020-03-17 13:23:58 -0400)
add jib example, improve dockerignores

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks merged commit 648b094 into master Mar 17, 2020
@nicks nicks deleted the nicks/jib branch March 17, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant