Run Reflection() class on functions generator#2
Merged
gchtr merged 1 commit intotimber:masterfrom Apr 26, 2024
Merged
Conversation
gchtr
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @gchtr
I use teak in a private project to generate documentation. The functions generator is not running the same kind of method like
Teak\Reflection\Reflection::shouldIgnore. So all functions, api or private, they all end up in the generated docs.This PR runs the Reflection class on functions reference generator so non-api functions wont end up in the docs.
I think we are no longer running
generate:function-referencein the Timber docs so this should not be a breaking change for Timber projects. Let me know what you think!