1974 wpml menu fix

[jarednova]

Ticket: #1974

Issue

The last WPML language switcher menu item was picking up the prior item's classes

Solution

While we want to use the WP_Post object (as opposed to the Timber-based object) to pull classes from, we need to clear its value to prevent the issue from occurring

Impact

This fixes #1974 (including @mgarabedian related issue). Unlike #2009, this isn't WPML-specific

Usage Changes

None

Testing

I tested locally against a real WPML instance and verified the fix. I don't think new tests are necessary since this removes a bug vs. creating a feature

[codecov]

Codecov Report

Merging #2013 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2013      +/-   ##
============================================
+ Coverage     95.01%   95.01%   +<.01%     
  Complexity     1570     1570              
============================================
  Files            49       49              
  Lines          3708     3710       +2     
============================================
+ Hits           3523     3525       +2     
  Misses          185      185

Impacted Files	Coverage Δ	Complexity Δ
lib/Menu.php	92.12% <100%> (+0.12%)	51 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d761e4...2476136. Read the comment docs.

[coveralls]

Coverage increased (+0.003%) to 94.266% when pulling 8b6cea8 on 1974_wpml_menu_fix into 137aa59 on master.

[jarednova]

This is ready for your review @palmiak !

[palmiak]

@jarednova do we have some access to latest WPML? I only have some older version from some project.

[jarednova]

@palmiak yeah, they gave me a dev copy to test against. I'll email you what I've got

[roberrrt-s]

Hi @jarednova does this commit fix issue #2020 ?

[jarednova]

@roberrrt-s #2020 is resolved by a (pending) upgrade to WPML that will synchronize versions of Twig. Once it's released I'll test to verify and then (very loudly) annouce