fix(config)!: require encoding for console and file sinks

[lukesteensen]

Closes #1031

There were a handful of small-ish issues preventing things from working the way our coercer guide claims they should:

1. The example timestamp format string didn't match the example data
2. We weren't logging the failure to convert types from (1) at a level that's visible by default
3. We forgot the console and file sinks when fixing Update sink encoding to be non optional #806, so even when (1) and (2) were addressed the console sink wouldn't output the event
4. There were a couple of typos in the config metadata that gave them incorrect docs

This is a breaking change for both the console and file sinks, since the encoding field is no longer optional.

Upgrade guide

1. If you're using the console sink add the encoding option:

   [sinks.print]
     type = "console"
     encoding = "json" # or text

2. If you're using the file sink add the encoding option:

   [sinks.file_out]
     type = "file"
     encoding = "ndjson" # or text

[binarylogic]

@LucioFranco shouldn't this have been resolved in #894? I assume we just missed this? Making sure this wasn't intentional.

[LucioFranco]

I believe I discussed this with you or luke but the reason this sink allows a null encoding is that it makes sense here to auto change how logs are printed since this is a debug sink. Happy to go the other way but for me this one actually made sense to dynamically choose since the downstream service is a human instead of a machine that might expect an encoding.

[binarylogic]

I don't remember having that conversation. Do you have this documented anywhere? It should be in Github or Slack somewhere, correct?

[lukesteensen]

I'd have been ok with leaving it, but I only noticed this because the logic was complex enough that we skipped an entire case and weren't outputting anything at all. That convinced me we should simplify.

[binarylogic]

👍 I believe this transform was merged before we had rate limiting. Unfortunately, #628 didn't cover this transform. I'll do another pass to make sure we're not missing anything new.

[binarylogic]

This all looks great! Thanks for fixing.

[lukesteensen]

@binarylogic do you know why the semantic PR check is still pending? I thought I did it right...

[binarylogic]

It's the !. I opened zeke/semantic-pull-requests#73.

[LucioFranco]

I added a comment about encoding in console but I'm happy either way.

[binarylogic]

Anything holding this up from merging? I would merge regardless of the semantic check for now.