enhancement(file sink): Automatically create missing directories#1094
Merged
LucioFranco merged 7 commits intomasterfrom Nov 4, 2019
Merged
enhancement(file sink): Automatically create missing directories#1094LucioFranco merged 7 commits intomasterfrom
LucioFranco merged 7 commits intomasterfrom
Conversation
Closes #1043 Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
binarylogic
changed the title
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Contributor
Author
Member
lukesteensen
left a comment
lukesteensen
left a comment
There was a problem hiding this comment.
It seems like the tests now all cover the case where neither the directory nor the file exists before the sink starts. It'd be nice to have tests documenting our behavior in each of the possible combinations (i.e. existing directory and file, existing directory and nonexistent file, nonexistent directory).
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Contributor
Author
|
@lukesteensen "existing directory and file" is covered by each test anyways with how we reopen files to test that we appened and open. I've added a test where we just need to create the file and the dir already exists. So I think that covers all the cases. |
lukesteensen
approved these changes
Oct 31, 2019
scripts/generate/templates/docs/usage/configuration/sinks/file.md.erb
Outdated
Show resolved
Hide resolved
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1043
Signed-off-by: Lucio Franco luciofranco14@gmail.com