fix(observability): Improve topology tracing spans#1123
Merged
LucioFranco merged 2 commits intomasterfrom Oct 31, 2019
Merged
Conversation
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
lukesteensen
approved these changes
Oct 31, 2019
Member
lukesteensen
left a comment
lukesteensen
left a comment
There was a problem hiding this comment.
This was super easy to review, thanks! Nice minimal change.
| for (name, source) in &config.sources { | ||
| let (tx, rx) = mpsc::channel(1000); | ||
|
|
||
| let typetag = source.source_type(); |
Member
There was a problem hiding this comment.
What made you decide not to get these from typetag?
Contributor
Author
There was a problem hiding this comment.
Well we have SinkOutter etc that trait objectized really early and not allowing us to call the inhernt method. So I figured this was easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves the output of tracing spans. Span's now include the source/transform/sink type.
This internally refactors our topology
Tasktype to include metadata.Signed-off-by: Lucio Franco luciofranco14@gmail.com