Skip to content

chore(operations): Update grok to version 1.0.1#1124

Merged
2 commits merged intovectordotdev:masterfrom
daschl:patch-1
Oct 31, 2019
Merged

chore(operations): Update grok to version 1.0.1#1124
2 commits merged intovectordotdev:masterfrom
daschl:patch-1

Conversation

@daschl
Copy link
Copy Markdown
Contributor

@daschl daschl commented Oct 30, 2019

I've released 1.1.0 of grok, I think you want to use it!

@ghost
Copy link
Copy Markdown

ghost commented Oct 31, 2019

Hi @daschl, thank you!

However, I'm somewhat reluctant about adding onig 5.x as a dependency to Vector yet because it requires libclang to be installed system-wide until rust-onig/rust-onig#126 is merged or rust-lang/rust-bindgen#918 is resolved in some way. So I would prefer to depend on onig 4.3 for now, but just not use the unstable method Regex::capture_names which doesn't work on 32-bit architectures.

From my tests, except Regex::capture_names method, onig 4.x can be built and works fine on a variety of targets, including armv7-unknown-linux-musleabihf and x86_64-pc-windows-gnu.

@daschl
Copy link
Copy Markdown
Contributor Author

daschl commented Oct 31, 2019

@a-rodin no worries. I can do a 1.0.1 for you with just the change included?

@ghost
Copy link
Copy Markdown

ghost commented Oct 31, 2019

@daschl That would be great!

@ghost ghost changed the title chore(config) Update grok to version 1.1.0 chore(operations) Update grok to version 1.1.0 Oct 31, 2019
@ghost ghost changed the title chore(operations) Update grok to version 1.1.0 chore(operations): Update grok to version 1.1.0 Oct 31, 2019
I've released 1.0.1 of `grok`, I think you want to use it!

Signed-off-by: Michael Nitschinger <michael@nitschinger.at>
@daschl daschl changed the title chore(operations): Update grok to version 1.1.0 chore(operations): Update grok to version 1.0.1 Oct 31, 2019
@daschl
Copy link
Copy Markdown
Contributor Author

daschl commented Oct 31, 2019

@a-rodin released a 1.0.1, hope this should help

Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@ghost ghost merged commit 641bc42 into vectordotdev:master Oct 31, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants