fix(aws_cloudwatch_metrics sink): Fix metrics batch strategy in sinks#1141
Merged
loony-bean merged 1 commit intomasterfrom Nov 7, 2019
Merged
fix(aws_cloudwatch_metrics sink): Fix metrics batch strategy in sinks#1141loony-bean merged 1 commit intomasterfrom
loony-bean merged 1 commit intomasterfrom
Conversation
lukesteensen
approved these changes
Nov 7, 2019
Signed-off-by: Alexey Suslov <alexey.suslov@gmail.com>
loony-bean
force-pushed
the
metrics-batch-min
branch
from
7f3aed0 to
3f62d18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undoing recently introduced
batched_with_max, because it was not working as intended, and is basically not required.Used with MetricBuffer,
batched_with_minstrategy will make sure the buffer sent out either when it containbatch_sizemetrics sharp, or it has timed out.Ref #856