fix(elasticsearch sink): host is not required when provider is AWS#1164
Merged
fix(elasticsearch sink): host is not required when provider is AWS#1164
host is not required when provider is AWS#1164Conversation
Signed-off-by: Bruce Guenter <bruce@untroubled.org>
Signed-off-by: Bruce Guenter <bruce@untroubled.org>
bruceg
added
type: bug
Contributor
|
Ref #1084 will be changing the implementation of this. |
Member
Author
Contributor
|
Just noting it's related, no changes necessary here. I want to package all of those changes into a single release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The elasticsearch has a
hostconfiguration setting that was non-optional, but the AWS provider does not actually require it as it can be worked out from either the region or endpoint settings. This change fixes this extraneous requirement.Fixes #1162