enhancement(json_parser transform): Add support for target field configuration#1165
Merged
enhancement(json_parser transform): Add support for target field configuration#1165
Conversation
This causes the parsed JSON to be inserted into the log as a sub-object with the given name. Signed-off-by: Bruce Guenter <bruce@untroubled.org>
Signed-off-by: Bruce Guenter <bruce@untroubled.org>
lukesteensen
approved these changes
Nov 12, 2019
Member
lukesteensen
left a comment
There was a problem hiding this comment.
I do think it should be possible to overwrite an existing field, mostly because it leads to the output being more consistent. That's not quite as straightforward with our current data model as it will be when we have nested fields, so maybe something we implement as a follow-up.
Maybe it could be an option to add an additional config parameter |
c5fdd23 to
26adccd
Compare
Signed-off-by: Bruce Guenter <bruce@untroubled.org>
lukesteensen
approved these changes
Nov 14, 2019
Signed-off-by: Bruce Guenter <bruce@untroubled.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for a new
target_fieldconfiguration that prefixes the parsed JSON object with the given name, producing a sub-object.Closes #1158