fix(grok_parser transform): don't drop parsed field#1172
Merged
lukesteensen merged 2 commits intomasterfrom Nov 13, 2019
Merged
fix(grok_parser transform): don't drop parsed field#1172lukesteensen merged 2 commits intomasterfrom
lukesteensen merged 2 commits intomasterfrom
Conversation
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
bruceg
reviewed
Nov 13, 2019
| let mut drop_field = self.drop_field; | ||
| if let Some(value) = value { | ||
| if let Some(matches) = self.pattern.match_against(&value) { | ||
| for (name, value) in matches.iter() { |
Member
There was a problem hiding this comment.
Could drop_field be calculated here as:
let drop_field = self.drop_field and !matches.contains_key(&self.field);
This would elimiate the let mut
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
bruceg
approved these changes
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #1166, the grok parser has a problem handling cases where a parsed field name is the same as the source field name.