enhancement(http sink): Add JSON encoding option#1174
Merged
binarylogic merged 5 commits intovectordotdev:masterfrom Nov 25, 2019
Merged
enhancement(http sink): Add JSON encoding option#1174binarylogic merged 5 commits intovectordotdev:masterfrom
binarylogic merged 5 commits intovectordotdev:masterfrom
Conversation
Basically just the same as NDJSON, except you delimit with , and then wrap in an array.
Contributor
|
Thanks @jamessewell! @lukesteensen, since @LucioFranco is out I wouldn't mind you taking a quick look at this. |
lukesteensen
suggested changes
Nov 14, 2019
Member
lukesteensen
left a comment
lukesteensen
left a comment
There was a problem hiding this comment.
Looks good, thank you!
So that the docs stay up to date, could you add the new encoding type to the list here?
src/sinks/http.rs
Outdated
| Encoding::Ndjson => builder.header("Content-Type", "application/x-ndjson"), | ||
| Encoding::Json => { | ||
| body.insert(0, b'['); | ||
| body.pop(); |
Member
There was a problem hiding this comment.
This is the trailing comma from the last record we need to remove? Might be worth a little comment.
Signed-off-by: Ben Johnson <bjohnson@binarylogic.com>
Signed-off-by: Ben Johnson <bjohnson@binarylogic.com>
Signed-off-by: Ben Johnson <bjohnson@binarylogic.com>
Contributor
Author
|
Amazing - sorry I didn’t get this one over the line myself! |
Member
|
No worries, thanks for getting it started! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically just the same as NDJSON, except you delimit with , (not \n) and then
remove the final , and wrap in an array.