Skip to content

fix(cli): Test & validate subcommands without args target default path#1313

Merged
Jeffail merged 3 commits intomasterfrom
subcmds-default-config-path
Dec 5, 2019
Merged

fix(cli): Test & validate subcommands without args target default path#1313
Jeffail merged 3 commits intomasterfrom
subcmds-default-config-path

Conversation

@Jeffail
Copy link
Copy Markdown
Contributor

@Jeffail Jeffail commented Dec 4, 2019

This commit makes the test and validate subcommands target the default config path in the absense of path arguments.

Closes #1310

Signed-off-by: Ashley Jeffs ash@jeffail.uk

This commit causes the test and validate subcommands to target the
default config path in the absense of path arguments.

Closes #1310

Signed-off-by: Ashley Jeffs <ash@jeffail.uk>
@Jeffail Jeffail requested a review from lukesteensen as a code owner December 4, 2019 19:16
@Jeffail Jeffail requested a review from LucioFranco December 4, 2019 19:17
Signed-off-by: Ashley Jeffs <ash@jeffail.uk>
Copy link
Copy Markdown
Member

@lukesteensen lukesteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Added one note, but nothing that needs to block merging.

Signed-off-by: Ashley Jeffs <ash@jeffail.uk>
@Jeffail Jeffail requested a review from bruceg as a code owner December 5, 2019 11:35
@Jeffail Jeffail merged commit e776d3a into master Dec 5, 2019
@Jeffail Jeffail deleted the subcmds-default-config-path branch December 5, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: validate sub command defaults to standard configuration path

2 participants