fix(cli): Use temporary wasm artifact_cache directory during validate command#4497
fix(cli): Use temporary wasm artifact_cache directory during validate command#4497
wasm artifact_cache directory during validate command#4497Conversation
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
|
cc @Hoverbear |
Hoverbear
left a comment
There was a problem hiding this comment.
So, I'm worried this work will be for nothing as we plan to migrate to wasmtime in the future which does not have the concept of an artifact cache (it's a JIT with a store like https://docs.rs/wasmtime/0.20.0/wasmtime/struct.Store.html, instead).
Do you think if we remove the artifact cache these new features in validate will be a worthwhile maintenance burden?
|
I was already on the edge if this fix is worth it, so if the issue will be resolved on it's own later, yea, this isn't worthy of maintenance. I'll see if there is some lighter(but hackier) fix, if not, I think we can leave it as it is since it has specific conditions of validate + different access group + |
|
I don't see a lighter way to fix this than this PR, so I'll add a description/reasoning in the issue and close this. |
Ref #3930
To avoid creating directories and caches in runtime directory we:
Open questions
wasmtransform configuration than passingBuildModearound?