-
Notifications
You must be signed in to change notification settings - Fork 8
Description
What would you like to be added:
- rename the
ClusterRingresource toControllerRing - drop the
clusterring-part of shard and drain label keys - drop
kindandnamespaceparams from allshardingv1alpha1.*functions - drop the kind-related and namespace labels from metrics
-
drop theshardring.Ringinterface
Why is this needed:
Originally, I envisioned that there could be two implementations of a "controller ring" resource: a namespaced one (Ring) and a cluster-scoped one (ClusterRing). The first one would only shard objects in the same namespace, the second one in all namespaces.
With the existing namespaceSelector field of the ClusterRing resource, one can simply implement a namespaced or even multi-namespaced controller ring.
Also, the resulting MutatingWebhookConfiguration is a cluster-scoped object and, thus, can only be owned by other cluster-scoped objects but not by namespaced ones.
Furthermore, implementing both versions of the resource would require one controller each.
In the end, there doesn't seem to be a good reason for implementing a namespaced version of the ClusterRing resource.
Hence, I suggest renaming the resource from ClusterRing to ControllerRing – which is more specific and less confusing.
With this, all places that kept options open for handling namespaced rings can be simplified.
Metadata
Metadata
Assignees
Labels
Projects
Status