Pin CI to go 1.25.0 and golangci-lint 2.8.0 exactly#195
Open
mtlynch wants to merge 2 commits intotimelinize:mainfrom
Open
Pin CI to go 1.25.0 and golangci-lint 2.8.0 exactly#195mtlynch wants to merge 2 commits intotimelinize:mainfrom
mtlynch wants to merge 2 commits intotimelinize:mainfrom
Conversation
This change pins CI to use go 1.25.0 and golangci-lint to 2.8.0 so that changes outside this repo don't cause CI to break out from under us. In 01063cf, CI passed, and then in 0169e2b, CI began to fail though not due to anything in the commit itself. Every commit since then has failed CI, which drastically devalues CI through alarm fatigue (https://en.wikipedia.org/wiki/Alarm_fatigue). The last passing commit's CI ran with golangci-lint 2.8.0 (https://github.com/timelinize/timelinize/actions/runs/21487184099/job/61899566316). The first failing commit ran with golangci-lint 2.11.4 (https://github.com/timelinize/timelinize/actions/runs/23951998278/job/69861473343). 2.11.4 added checks that caused existing issues in the codebase to break CI. CI should not break out from under us when there have been no changes. We should regularly update to the latest and greatest static analysis tools and linters, but that should happen in a commit where we explicitly choose to upgrade, not automatically during other changes. I also pinned to instead of because using go 1.26.0 breaks pinned tooling that expects go 1.25.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change pins CI to use go 1.25.0 and golangci-lint to 2.8.0 so that changes outside this repo don't cause CI to break out from under us.
In 01063cf, CI passed, and then in 0169e2b, CI began to fail though not due to anything in the commit itself. Every commit since then has failed CI, which drastically devalues CI through alarm fatigue.
The last passing commit's CI ran with golangci-lint 2.8.0. The first failing commit ran with golangci-lint 2.11.4. 2.11.4 added checks that caused existing issues in the codebase to break CI.
CI should not break out from under us when there have been no changes. We should regularly update to the latest and greatest static analysis tools and linters, but that should happen in a commit where we explicitly choose to upgrade, not automatically during other changes.
I also pinned
go-versionto1.25.0instead ofstablebecause using go 1.26.0 breaks pinned tooling that expects go 1.25.0.I also had to partially roll back 9ad4fa1, as golangci-lint fails on unused warning suppressions, and the warnings we suppressed in that commit are for errors that golanci-lint 2.8.0 does not flag.
Assistance Disclosure
I used AI to find the correct GitHub CI semantics but verified the results.