refactor: monolith to dedicated features#177
Merged
Conversation
…pters and tests for all necessary layers), without tests, deps and adapters – users, timers; added ':core' module with all 'core' types that applicable for every feature.
vadickkt
approved these changes
Feb 11, 2024
Member
vadickkt
left a comment
vadickkt
left a comment
There was a problem hiding this comment.
I don't know is the logic correct, but code is correct!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is it breaking change?
For public API – No, but it's a big internal change.
Have you synchronized changes with other repositories?
No need in it.
Explain why this change is important
Explain the importance of the change.
Specify linked issues or discussions
closes #176
Additional information
In addition, I rewrote FSM from scratch giving ability to declare it as DSL avoiding logic in the entities.