Skip to content

fix smoke test for disable backfill sorting #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 16, 2024
Merged

fix smoke test for disable backfill sorting #477

merged 4 commits into from
Jan 16, 2024

Conversation

@yl-lisen
Copy link
Collaborator

@yl-lisen yl-lisen commented Jan 10, 2024

PR checklist:

  • Did you run ClangFormat ?
  • Did you separate headers to a different section in existing community code base ?
  • Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:

@yl-lisen yl-lisen self-assigned this Jan 10, 2024
@yl-lisen yl-lisen requested a review from chenziliang January 10, 2024 04:33
@yl-lisen yl-lisen force-pushed the enhancement/issue-475-disable-backfill-sorting-by-default branch from b94b764 to 5344d5d Compare January 10, 2024 14:56
@yl-lisen yl-lisen force-pushed the enhancement/issue-475-disable-backfill-sorting-by-default branch from 5344d5d to 49e5ac3 Compare January 10, 2024 15:05
chenziliang
chenziliang reviewed Jan 15, 2024
View reviewed changes
chenziliang
chenziliang reviewed Jan 15, 2024
View reviewed changes
chenziliang
chenziliang reviewed Jan 15, 2024
View reviewed changes
chenziliang
chenziliang reviewed Jan 15, 2024
View reviewed changes
chenziliang
chenziliang reviewed Jan 15, 2024
View reviewed changes
chenziliang
chenziliang reviewed Jan 15, 2024
View reviewed changes
@yl-lisen yl-lisen force-pushed the enhancement/issue-475-disable-backfill-sorting-by-default branch 2 times, most recently from 963663f to 05607db Compare January 15, 2024 08:31
@yl-lisen yl-lisen force-pushed the enhancement/issue-475-disable-backfill-sorting-by-default branch from 05607db to 8ce6bed Compare January 15, 2024 11:13
@yokofly yokofly mentioned this pull request Jan 16, 2024
Merged
@qijun-niu-timeplus qijun-niu-timeplus self-requested a review January 16, 2024 03:45
@proton-robot proton-robot merged commit c64ec3d into develop Jan 16, 2024
@yokofly yokofly deleted the enhancement/issue-475-disable-backfill-sorting-by-default branch January 16, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenziliang chenziliang chenziliang left review comments

+1 more reviewer

@qijun-niu-timeplus qijun-niu-timeplus qijun-niu-timeplus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yl-lisen yl-lisen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yl-lisen @chenziliang @qijun-niu-timeplus @proton-robot @yokofly