Skip to content

make file storage unsupport streaming query #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

make file storage unsupport streaming query #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb634a6
make file storage unsupport streaming query
Jan 11, 2024
e3d8742
Merge branch 'develop' into bugfix/issue-469-make-file-storage-unsupp…
lizhou1111 Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Storages/FileLog/StorageFileLog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,8 @@ class StorageFileLog final : public shared_ptr_helper<StorageFileLog>, public IS

void deserialize();
static void checkOffsetIsValid(const String & full_name, UInt64 offset);

bool supportsStreamingQuery() const override { return true; }
};

}
2 changes: 0 additions & 2 deletions src/Storages/StorageFile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ friend class PartitionedStorageFileSink;

static SchemaCache & getSchemaCache(const ContextPtr & context);

bool supportsStreamingQuery() const override { return true; }

protected:
friend class StorageFileSource;
friend class StorageFileSink;
Expand Down