Skip to content

enhancement: input_format_skip_unknown_fields default to true for external streams #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024
Merged

enhancement: input_format_skip_unknown_fields default to true for external streams #550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Storages/ExternalStream/StorageExternalStreamImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@ namespace DB
class StorageExternalStreamImpl : public std::enable_shared_from_this<StorageExternalStreamImpl>
{
public:
explicit StorageExternalStreamImpl(std::unique_ptr<ExternalStreamSettings> settings_): settings(std::move(settings_)) {}
explicit StorageExternalStreamImpl(std::unique_ptr<ExternalStreamSettings> settings_): settings(std::move(settings_)) {
/// Make it easier for people to ingest data from external streams. A lot of times people didn't see data coming
/// only because the external stream does not have all the fields.
if (!settings->input_format_skip_unknown_fields.changed)
settings->input_format_skip_unknown_fields = true;
}
virtual ~StorageExternalStreamImpl() = default;

virtual void startup() = 0;
Expand Down