fix(proton): eliminate float64 precision loss and add column order guard#67
Merged
fix(proton): eliminate float64 precision loss and add column order guard#67
Conversation
Two fixes for the columnar insert fast path: 1. Float64 precision: The buffer-replay goroutine could process the first rows before ApplyTargetCastPlan set the fast cast plan, causing those rows to fall through to CastRow which applies max_decimals=11 truncation. Add a castPlanReady channel so the goroutine waits for the plan (or pause signal) before replaying buffer rows. Signal deterministically from: - ApplyTargetCastPlan (Proton targets, first stream) - PushStreamChan (subsequent streams with plan already set) - Unpause (all database targets, after setup is complete) - WriteToFile (file/stdout targets, no Pause/Unpause cycle) - WaitReady (standalone consumers like Collect) 2. Column order guard: The columnar buffer uses positional indexing, so column order mismatches would silently corrupt data. Add verifyColumnOrder() check per-batch that fails fast on mismatch. Includes regression tests for both fixes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for the columnar insert fast path:
Float64 precision: The buffer-replay goroutine could process the first rows before ApplyTargetCastPlan set the fast cast plan, causing those rows to fall through to CastRow which applies max_decimals=11 truncation. Add a castPlanReady channel so the goroutine waits for the plan (or pause signal) before replaying buffer rows. Signal deterministically from:
Column order guard: The columnar buffer uses positional indexing, so column order mismatches would silently corrupt data. Add verifyColumnOrder() check per-batch that fails fast on mismatch.
Includes regression tests for both fixes.