refactor(eval): split correlation_engine.rs into module directory#49
Merged
Conversation
Modularize the 4395-line correlation_engine.rs into focused submodules
for maintainability. No logic, behavior, or API changes -- pure
restructuring with identical test results (366 tests pass).
New structure:
correlation_engine/
mod.rs -- engine struct, impl, timestamp helpers
types.rs -- config enums, result types, snapshot
tests.rs -- all unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/rsigma-eval/src/correlation_engine.rs(4395 lines) into acorrelation_engine/module directory with 3 submodules for better maintainabilityTest plan
cargo fmt --all -- --checkpassescargo clippy --workspace --all-targets --all-features -- -D warningspasses (zero warnings)cargo test -p rsigma-evalpasses (366 unit tests + 37 integration/doc tests, 0 failures)