refactor(eval): extract pipeline parsing and tests from mod.rs#52
Merged
Conversation
Extract YAML parsing logic and tests from the 2235-line pipeline/mod.rs into dedicated sibling modules. No behavior changes; identical test results (366 unit tests + 47 others pass). New/modified files: pipeline/mod.rs -- structs, apply logic, merge/apply functions (448 lines, was 2235) pipeline/parsing.rs -- all YAML parsing and condition parsing (817 lines) pipeline/tests.rs -- all unit tests (982 lines)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/rsigma-eval/src/pipeline/mod.rs(2235 lines) intoparsing.rsandtests.rs, reducingmod.rsto 448 linesTest plan
cargo fmt --all -- --checkpassescargo clippy --workspace --all-targets --all-features -- -D warningspasses (zero warnings)cargo test -p rsigma-evalpasses (366 unit tests + 47 integration/doc tests, 0 failures)