Skip to content

refactor(eval): split event.rs into module directory#57

Merged
mostafa merged 1 commit into
mainfrom
feat/modularize-event
Apr 30, 2026
Merged

refactor(eval): split event.rs into module directory#57
mostafa merged 1 commit into
mainfrom
feat/modularize-event

Conversation

@mostafa
Copy link
Copy Markdown
Member

@mostafa mostafa commented Apr 30, 2026

Summary

  • Split crates/rsigma-eval/src/event.rs (758 lines) into event/ module directory
  • Extract EventValue enum, Event trait, and blanket impls into event/mod.rs
  • Move each concrete implementation to its own file:
    • event/json.rs - JsonEvent + traverse/collect helpers (14 tests)
    • event/kv.rs - KvEvent (3 tests)
    • event/plain.rs - PlainEvent (3 tests)
    • event/map.rs - MapEvent (2 tests)
  • EventValue coercion tests remain in event/mod.rs (4 tests)

Test plan

  • cargo fmt --all -- --check passes
  • cargo clippy --workspace --all-targets --all-features -- -D warnings passes
  • cargo test --workspace passes (970+ tests across all crates)

@mostafa mostafa merged commit 49b02af into main Apr 30, 2026
8 checks passed
@mostafa mostafa deleted the feat/modularize-event branch April 30, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant