fix(hardening): add SIGTERM handler, parking_lot mutex, event size cap#74
Merged
Conversation
mostafa
force-pushed
the
fix/security-critical
branch
from
c78c56f to
3c8e980
Compare
- Add shutdown_signal() that handles both SIGINT and SIGTERM on Unix, replacing bare ctrl_c() calls in both OTLP and non-OTLP serve paths - Replace std::sync::Mutex with parking_lot::Mutex in processor.rs, eliminating 7 .lock().unwrap() sites that could panic on poisoning - Add 1MB per-line size cap to /api/v1/events HTTP endpoint to prevent memory exhaustion from oversized payloads - Document reload channel backpressure design (bounded capacity 4 with 500ms debounce + try_recv drain)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #71.
std::sync::Mutexwithparking_lot::Mutexinprocessor.rs, eliminating 7.lock().unwrap()call sites/api/v1/eventshandler, returning 413 Payload Too LargeTest plan
cargo checkpasses withparking_lot::Mutex