fix(quality): add KEY_CACHE completeness test, replace partial_cmp with total_cmp#75
Merged
Conversation
mostafa
force-pushed
the
fix/security-critical
branch
from
c78c56f to
3c8e980
Compare
mostafa
force-pushed
the
fix/code-quality
branch
2 times, most recently
from
d081938 to
2a56d7f
Compare
…th total_cmp
- Add exhaustive test that verifies all lint key strings are present in
KEY_CACHE, turning a runtime panic into a test-time failure
- Replace partial_cmp().expect("NaN filtered") with f64::total_cmp()
in window.rs percentile/median calculations, eliminating panic on NaN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #71.
KEY_CACHE, turning a runtime panic into a test-time failurepartial_cmp().expect("NaN filtered")withf64::total_cmp()inwindow.rspercentile/median calculations, eliminating potential panic on NaNTest plan
all_lint_keys_are_cachedtest passestotal_cmp