Conversation
nathanjcochran
approved these changes
Oct 7, 2025
Member
nathanjcochran
left a comment
There was a problem hiding this comment.
Left a couple minor comments, but no show-stoppers. Looks good to me ✅
I definitely think there's more we could do to clean up the error handling, but that could be done in a follow-up. This gets the job done for now 👍.
cevian
reviewed
Oct 8, 2025
Contributor
cevian
left a comment
There was a problem hiding this comment.
Looked over this and looks reasonable but will let @nathanjcochran take lead on review. Suggest to add text to CLAUDE.md to specify how this should be handled
f2ebcfc to
546173d
Compare
d06b4c0 to
8fc79c8
Compare
8fc79c8 to
c4005d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on: https://github.com/timescale/savannah-public/pull/49
The errors for these cases are still suboptimal:
Will dive a bit deeper into graphql to try get better errors. At least it should be propagated with this.