Conversation
graveland
commented
Oct 23, 2025
graveland
force-pushed
the
brent/contexts
branch
from
6c82d02 to
0bc7923
Compare
graveland
force-pushed
the
brent/contexts
branch
4 times, most recently
from
839eaa4 to
bea092c
Compare
graveland
force-pushed
the
brent/contexts
branch
from
bf6896d to
0d269e8
Compare
Stop using context.Background() and use a root context that's got signal.NotifyContext() on it. This allows control-C to interrupt everything. Use the main context for the MCP handler as well
graveland
force-pushed
the
brent/contexts
branch
from
0d269e8 to
6d3bc32
Compare
nathanjcochran
approved these changes
Oct 24, 2025
Member
There was a problem hiding this comment.
Left a comment about a couple other places where we should use the new readString function, so that reading from stdin can be canceled via ctrl-c. Might want to move that readString function into the util package or something, given that we'll probably end up using it in a bunch of different places.
Other than that, this LGTM!
graveland
force-pushed
the
brent/contexts
branch
from
b6ced91 to
cc143ed
Compare
graveland
force-pushed
the
brent/contexts
branch
from
cc143ed to
9a82a02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop using context.Background() and use a root context that's got signal.NotifyContext() on it. This allows control-C to interrupt everything.