- 
                Notifications
    
You must be signed in to change notification settings  - Fork 60
 
Refactoring CI configuration to make it simpler and similar to promscale #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           This would allow us to set up branch restriction rules.  | 
    
23e66cf    to
    aad0f03      
    Compare
  
    | 
           CI won't start as the workflow is completely rewritten and does not exist on   | 
    
| 
           @paulfantom  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. a few comments
        
          
                .github/workflows/cli.yml
              
                Outdated
          
        
      | name: e2e results | ||
| if: always() | ||
| needs: | ||
| - test-end-to-end | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the error for why the ci won't run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct, this part is wrong and should be just - e2e. However, CI won't run for a different reason - it won't run because the workflow name changed and the new name is not present on master branch. This is some sort of DoS prevention mechanism on GitHub side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs to be fixed.
aad0f03    to
    aee55d2      
    Compare
  
    | 
           Rebased and addressed code review comments.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except that one issue with cli.yml that still needs fixing (name of the dependent test)
        
          
                .github/workflows/cli.yml
              
                Outdated
          
        
      | name: e2e results | ||
| if: always() | ||
| needs: | ||
| - test-end-to-end | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs to be fixed.
3caf768    to
    3698c5a      
    Compare
  
    …to promscale Signed-off-by: Paweł Krupa (paulfantom) <pawel@krupa.net.pl>
3698c5a    to
    833f931      
    Compare
  
    
As in title.
Main changes: