Skip to content

fix typo in README #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2022
Merged

fix typo in README #235

merged 2 commits into from
Feb 15, 2022

Conversation

@NsrWissam
Copy link
Contributor

@NsrWissam NsrWissam commented Feb 14, 2022

tobs-credentails -> tobs-credentials

@NsrWissam
fix typo
051d310 
tobs-credentails -> tobs-credentials
@NsrWissam NsrWissam requested a review from a team as a code owner February 14, 2022 10:50
@CLAassistant
Copy link

CLAassistant commented Feb 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@NsrWissam NsrWissam changed the title fix typo fix typo in documentation Feb 14, 2022
@NsrWissam NsrWissam changed the title fix typo in documentation fix typo in README Feb 14, 2022
@JamesGuthrie
Copy link
Member

JamesGuthrie commented Feb 14, 2022

@NsrWissam Thanks for this contribution. There is another occurrence in ./chart/docs/upgrades.md, could you replace that one too?

@NsrWissam
Copy link
Contributor Author

NsrWissam commented Feb 14, 2022

@NsrWissam Thanks for this contribution. There is another occurrence in ./chart/docs/upgrades.md, could you replace that one too?

Done !

JamesGuthrie
JamesGuthrie approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@JamesGuthrie JamesGuthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NsrWissam
Copy link
Contributor Author

NsrWissam commented Feb 14, 2022

Can we retry this build ? it seems there was some timeout unrelated to the changes

@paulfantom paulfantom merged commit 4e659cc into timescale:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesGuthrie JamesGuthrie JamesGuthrie approved these changes

@paulfantom paulfantom Awaiting requested review from paulfantom paulfantom was automatically assigned from timescale/o11y-eng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NsrWissam @CLAassistant @JamesGuthrie @paulfantom