*: remove static deployment manifests #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #237 |
Signed-off-by: Paweł Krupa (paulfantom) <pawel@krupa.net.pl>
paulfantom
force-pushed
the
no-static-deployment
branch
from
8a6fa13 to
329406a
Compare
|
Moving from draft to review as we agreed on this in tobs future meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title.
Reasoning behind this change is that in those manifests we are setting database password to a well-known string and distributing it in multiple places. After deploying, this is hard to change and quite problematic. Instead we should be pointing folks to use CLI or helm charts.
@cevian @VineethReddy02 I don't intend to merge it now as this is something we should talk about.