Skip to content

chart: use proper types for enabling parts of the stack #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2022
Merged

chart: use proper types for enabling parts of the stack #249

merged 1 commit into from
Feb 18, 2022

Conversation

@paulfantom
Copy link
Contributor

@paulfantom paulfantom commented Feb 16, 2022

Fixing type-casting issues

Requires timescale/promscale#1159

@paulfantom paulfantom requested a review from a team as a code owner February 16, 2022 15:11
@paulfantom
Copy link
Contributor Author

paulfantom commented Feb 16, 2022

Fixes #231

@paulfantom paulfantom mentioned this pull request Feb 16, 2022
Merged
@paulfantom
Copy link
Contributor Author

paulfantom commented Feb 16, 2022

Blocked by lack of promscale chart being released.

@paulfantom
Copy link
Contributor Author

paulfantom commented Feb 17, 2022

Requires #251

@paulfantom
Copy link
Contributor Author

paulfantom commented Feb 17, 2022

Rebased and it is ready to be merged.

@paulfantom paulfantom enabled auto-merge February 17, 2022 16:36
@paulfantom paulfantom merged commit 595c1ff into timescale:master Feb 18, 2022
@paulfantom paulfantom deleted the typecast branch February 18, 2022 12:00
@paulfantom paulfantom mentioned this pull request Feb 18, 2022
Closed
@paulfantom paulfantom linked an issue Feb 18, 2022 that may be closed by this pull request
type error in values.yaml "'timescaledb-single.enabled' for chart timescaledb-single returned non-bool value" #250
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antekresic antekresic antekresic approved these changes

@niksajakovljevic niksajakovljevic Awaiting requested review from niksajakovljevic niksajakovljevic was automatically assigned from timescale/o11y-eng

@harkishen harkishen Awaiting requested review from harkishen harkishen was automatically assigned from timescale/o11y-eng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

type error in values.yaml "'timescaledb-single.enabled' for chart timescaledb-single returned non-bool value"

2 participants

@paulfantom @antekresic