Skip to content

Conversation

@paulfantom
Copy link
Contributor

@paulfantom paulfantom commented May 30, 2022

Description

Using SQLite would allow us to still use grafana when database is down or under high pressure.

This is a breaking change.

Fixes #338

Type of change

What type of changes does your code introduce to tobs? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

@paulfantom paulfantom force-pushed the grafana-storage branch 2 times, most recently from 9b13aa3 to 4def627 Compare May 31, 2022 10:36
@paulfantom paulfantom force-pushed the grafana-storage branch 8 times, most recently from 6e6706d to 0cbf974 Compare June 14, 2022 12:24
annotations:
"helm.sh/resource-policy": keep
type: Opaque
{{- if (($grafana.timescale).database).enabled }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: parenthesis here allow to have each level be nullable and thus prevent issues with nil pointer evaluating interface when higher level object doesn't exist.

@paulfantom
Copy link
Contributor Author

After merging this we are defaulting to sqlite database for grafana. Configuration for timescaledb is still present for users who upgrade from previous tobs versions, but will be removed in tobs 0.12.0.

By default upgrade will switch grafana to use sqlite3 and if user wants to stay on timescaledb backend, they need to set:

kube-prometheus-stack:
  grafana:
    timescale:
      database:
        enabled: true

@paulfantom paulfantom requested a review from onprem June 14, 2022 12:30
@paulfantom paulfantom marked this pull request as ready for review June 14, 2022 12:30
@paulfantom paulfantom requested a review from a team as a code owner June 14, 2022 12:30
@paulfantom paulfantom force-pushed the grafana-storage branch 5 times, most recently from b3f1d12 to be52cf9 Compare June 16, 2022 10:56
@paulfantom paulfantom marked this pull request as draft June 16, 2022 10:56
@paulfantom paulfantom marked this pull request as ready for review June 16, 2022 12:01
Copy link
Contributor

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulfantom paulfantom merged commit d615c91 into timescale:master Jun 16, 2022
@paulfantom paulfantom deleted the grafana-storage branch June 16, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch grafana to use SQLite instead of using timescaledb instance

2 participants