chart: deploy alertmanager in HA mode #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfantom
force-pushed
the
ha-alertmanager
branch
from
7c1a488 to
c2bcf3c
Compare
paulfantom
commented
Jun 16, 2022
|
|
||
| // FIXME(paulfantom): This should be converted into polling for instances | ||
| time.Sleep(3 * time.Minute) | ||
| time.Sleep(5 * time.Minute) |
There was a problem hiding this comment.
Since we are planning to refactor those tests and improve them all together I opted for a quick and dirty solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To ensure high-availability of the monitoring stack we should deploy prometheus as well as alertmanager in HA modes. Prometheus HA deployment was accomplished in #416. This PR is a continuation and ensures alertmanager is also running in HA.
This is also aligning tobs with prometheus-operator project recommendations regarding deployment topology.
Type of change
What type of changes does your code introduce to tobs? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)