Make CLI compatible with Forge #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
archen2019
commented
Jul 16, 2020
archen2019
commented
- Add port number to GF_DATABASE_HOST
- Read dbname and port number from values file
- OpenConnectionToDB now detects and supports external DB
cevian
requested changes
Jul 16, 2020
| {{- $isDefault := not $promEnabled -}} | ||
| {{- $root := . -}} | ||
| {{- $host := tpl .Values.grafana.timescale.database.host $root -}} | ||
| {{- $port := index .Values "timescale-prometheus" "connection" "port" | int -}} |
There was a problem hiding this comment.
it seems weird to have host in .Values.grafana.timescale.database.host and port in another place. Why don't we just add a key called .Values.grafana.timescale.database.port?
There was a problem hiding this comment.
Added, but we can't do it the same way as we did the hostname, since the port is an int. Helm conventions say not to put quotes around ints that arent environment variables, so we will have to just edit the port number in 3 places.
atanasovskib
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.