Skip to content

Rename CLI to tobs #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 23, 2020
Merged

Rename CLI to tobs #46

merged 7 commits into from
Jul 23, 2020

Conversation

@archen2019
Copy link
Contributor

No description provided.

@archen2019 archen2019 requested a review from cevian July 23, 2020 16:53
cevian
cevian requested changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for some nits and the directory name. I think instead of having the top level dir be tobs it should be cli. That's more descriptive and weird to have tobs directory inside of tobs repo.

archen2019 and others added 3 commits July 23, 2020 10:58
@archen2019 @cevian
Update tobs/README.md
919188e 
Co-authored-by: Matvey Arye <mat@timescale.com>
@archen2019 @cevian
Update tobs/README.md
61cffa2 
Co-authored-by: Matvey Arye <mat@timescale.com>
@archen2019
Rename folder to cli
02e47f0
cevian
cevian approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, and removing the dist dir and good to merge

archen2019 and others added 2 commits July 23, 2020 13:54
@archen2019 @cevian
Update cli/README.md
dc8014a 
Co-authored-by: Matvey Arye <mat@timescale.com>
@archen2019
Remove dist directory
4eca5c7
@archen2019 archen2019 merged commit 9e8ca3c into master Jul 23, 2020
@paulfantom paulfantom deleted the rename-cli branch February 15, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cevian cevian cevian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@archen2019 @cevian