Skip to content

♻️ Replace miette and owo-colors with codespan-reporting#118

Merged
timfennis merged 1 commit intomasterfrom
housekeeping/replace-miette-with-codespan-reporting
Mar 21, 2026
Merged

♻️ Replace miette and owo-colors with codespan-reporting#118
timfennis merged 1 commit intomasterfrom
housekeeping/replace-miette-with-codespan-reporting

Conversation

@timfennis
Copy link
Owner

@timfennis timfennis commented Mar 21, 2026

Summary

  • Replace miette with codespan-reporting for error diagnostics
  • Replace owo-colors with yansi (already a workspace dependency) for syntax highlighting
  • Use codespan's .with_code() for error phase labels (e.g. error[lexer], error[vm])
  • Convert InterpreterError directly to codespan Diagnostic, removing the intermediate NdcReport / Report struct
  • Fix disassemble error path to pass source code through so span labels render correctly
  • Document branch naming convention in CLAUDE.md

Test plan

  • All 267 tests pass
  • Clippy clean
  • cargo fmt applied
  • Manual check: run a script with an error and verify the diagnostic renders correctly
  • Manual check: REPL error rendering
  • Manual check: ndc highlight subcommand

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@timfennis timfennis enabled auto-merge (squash) March 21, 2026 20:53
@timfennis timfennis merged commit 05bf359 into master Mar 21, 2026
1 check passed
@timfennis timfennis deleted the housekeeping/replace-miette-with-codespan-reporting branch March 21, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant