🐛 Fix false 'not declared' error when destructuring reassigned variables#120
Merged
🐛 Fix false 'not declared' error when destructuring reassigned variables#120
Conversation
When a variable was declared as `()` and later reassigned to a tuple (e.g. `let pos = (); pos = (1, 2);`), destructuring it with `let a, b = pos;` would silently fail to declare `a` and `b` because the analyser saw an empty tuple and `zip` produced zero iterations. Now falls back to `Any` when a Tuple's arity doesn't match the number of lvalues, allowing the destructuring to proceed to runtime. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
()and later reassigned to a tuple (e.g.let pos = (); pos = (1, 2);), destructuring it withlet a, b = pos;would produce a false "Identifier a has not previously been declared" errorTuple([])), andzipwith an empty iterator silently produced zero bindings for the lvaluesTuple's arity doesn't match the number of lvalues in the destructuring, fall back toAnyfor each element instead of silently skipping themTest plan
bug0015_unpack_mismatched_tuple_arity.ndc🤖 Generated with Claude Code