Skip to content

Fix #81: add parallel option to headgrid for steady and transient models#83

Merged
dbrakenhoff merged 10 commits intodevfrom
headgrid_parallel
Apr 3, 2026
Merged

Fix #81: add parallel option to headgrid for steady and transient models#83
dbrakenhoff merged 10 commits intodevfrom
headgrid_parallel

Conversation

@dbrakenhoff
Copy link
Copy Markdown
Contributor

@dbrakenhoff dbrakenhoff commented Apr 2, 2026

  • use tqdm.thread_map for parallel + optional progressbar
  • deprecate printrow in favor of show_progress
  • add tqdm to optional dependencies
  • use parallel in some examples to speed up computations and test implementation

@dbrakenhoff
Add parallel option to headgrid for steady and transient models
97148be 
- use tqdm.thread_map for parallel  + optional progressbar
- deprecate printrow in favor of show_progress
- add tqdm to optional dependencies
- use parallel in some examples to speed up computations and test implementation
@dbrakenhoff dbrakenhoff requested review from Copilot and mbakker7 April 2, 2026 12:34
@dbrakenhoff dbrakenhoff self-assigned this Apr 2, 2026
@dbrakenhoff dbrakenhoff added the enhancement New feature or request label Apr 2, 2026
@dbrakenhoff dbrakenhoff linked an issue Apr 2, 2026 that may be closed by this pull request
Implement multi-processing for computing a headgrid of the solution #81
Open
Copilot AI reviewed Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an optional parallel execution path for computing headgrid in both steady and transient models (and wires it into contour plotting), while introducing a show_progress option and deprecating printrow. It also adds tqdm as an optional dependency to support the parallel/progress implementation.

Changes:

  • Add parallel/show_progress parameters to headgrid (steady + transient) and deprecate printrow.
  • Update steady/transient contour plotting helpers to forward parallel to headgrid.
  • Add a parallel optional dependency group (via tqdm) in pyproject.toml.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
timflow/transient/plots.py Adds parallel option to contour plotting and forwards it to headgrid.
timflow/transient/model.py Implements parallelized headgrid path with thread_map, adds show_progress, deprecates printrow.
timflow/steady/plots.py Adds parallel option to steady contour plotting and forwards it to headgrid.
timflow/steady/model.py Implements parallelized headgrid path with thread_map, adds show_progress, deprecates printrow.
pyproject.toml Adds tqdm under a new parallel optional dependency group and reformats pytest markers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dbrakenhoff and others added 8 commits April 2, 2026 15:23
@dbrakenhoff
Update timflow/transient/plots.py
d0bbfc6 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dbrakenhoff
Update timflow/transient/plots.py
1202ca2 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dbrakenhoff
Update timflow/transient/model.py
9ea9271 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dbrakenhoff
Update timflow/transient/model.py
83eb4f4 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dbrakenhoff
Update timflow/steady/plots.py
69c0579 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dbrakenhoff
Update timflow/steady/model.py
c358971 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dbrakenhoff
try import tqdm, and fall back to serial if import fails with useful …
5e91227 
…warning

 and improve some docstrings
@mbakker7
Update horizontal_well.ipynb
5967e94
@mbakker7
Copy link
Copy Markdown
Contributor

mbakker7 commented Apr 2, 2026

This looks nice. For the horizontalwell notebook, the contour function gets a speed up of 3 times (on my Mac with just a few cores). What doesn't work yet is the progress bar. When I do a headgrid on transient and specify show_progress=True, I get Error displaying widget: model not found.

@mbakker7
This fixes the progress bar
64fe3e1 
So that it also works in Jupyter Notebooks
mbakker7
mbakker7 approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mbakker7 mbakker7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this PR together so quickly.
I think it is ready to go.

@dbrakenhoff dbrakenhoff merged commit ea7b68b into dev Apr 3, 2026
11 checks passed
@dbrakenhoff dbrakenhoff deleted the headgrid_parallel branch April 3, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mbakker7 mbakker7 mbakker7 approved these changes

Assignees

@dbrakenhoff dbrakenhoff

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement multi-processing for computing a headgrid of the solution

3 participants

@dbrakenhoff @mbakker7