Vulkan Forward+: align tile cull with viewport-derived tile pixels#127
Merged
Merged
Conversation
- forward_plus_tile_cull.comp: sphere_tile_overlap uses dynamic tilePx from lights SSBO viewport and pc.tileGrid (no hard-coded 16px) - renderer_regression_check: forbid 16px literals in compute; note alignment - RENDERER_2026_ARCHITECTURE_PASS: document compute+fragment tile sizing - Regenerate SPIR-V for compute shader Co-authored-by: Tim Fox <timfox@outlook.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Security review completed for this PR.
I validated all modified code paths (forward_plus_tile_cull.comp, generated shader artifacts, and renderer_regression_check.sh) and found no medium/high/critical vulnerabilities introduced by this change.
Why no finding was filed:
- The shader change is arithmetic alignment (tile pixel size derived from viewport/tile grid), with no new attacker-controlled input crossing into a sensitive sink.
- The script change updates regression checks only and does not introduce a runtime trust-boundary or injection path.
- No prior automation-authored review threads were present to revalidate or keep open.
Sent by Cursor Automation: Find vulnerabilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align
forward_plus_tile_cull.compwith the PBR fragment Forward+ path: tile AABBs use viewport ÷ tileGrid instead of hard-coded 16px.Validation
./scripts/renderer_regression_check.sh,./scripts/compile_engine.sh vulkan.