ci: fix renderer_regression_check on Windows CRLF manifest checkout#137
Merged
cursor[bot] merged 2 commits intomainfrom Apr 22, 2026
Merged
Conversation
Windows git checkouts use CRLF for REGRESSION_REPO_MANIFEST.txt; paths kept a trailing \r so -f tests failed (58 manifest misses). Strip \r from each line before the existence check and GAME_BASE asset paths. Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Security review complete for this PR.
I found no new medium/high/critical vulnerabilities introduced by this change.
What I validated:
- The new
line="${line%$'\r'}"normalization inscripts/renderer_regression_check.shonly strips trailing carriage returns from manifest/asset-list lines. - No new attacker-controlled input reaches execution sinks (
eval, command substitution, process spawning, file writes, network calls, or privilege boundaries) as part of this change. - The behavior change is limited to path-string normalization for existing file-presence checks and does not expand permissions or trust boundaries.
No inline security findings to report.
Sent by Cursor Automation: Find vulnerabilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows GitHub Actions runners,
REGRESSION_REPO_MANIFEST.txtis often checked out with CRLF line endings. Each manifest path retained a trailing\r, so[ -f "$PROJECT_ROOT/$line" ]failed for every entry (~58 failures) even though the files exist.Fix
scripts/renderer_regression_check.sh: strip trailing\rfrom each line when reading the repo manifest and when readingOPTIONAL_GAME_ASSETS.txtunderGAME_BASE.Docs
docs/RENDERER_CONFIDENCE.md: note CRLF-safe manifest parsing in the Tier A table.Validation (Linux)
./scripts/renderer_regression_check.sh./scripts/compile_engine.shvulkan + opengl./scripts/smoke_test.shctest -R 'smoke_test|renderer_regression'./scripts/validate_ci_build.sh