ImGui: File menu (screenshot, console, quit) and Help About#176
Merged
Conversation
The menu item previously did nothing; it now appends "quit" to the command buffer so the client exits cleanly. Co-authored-by: Tim Fox <timfox@outlook.com>
Add screenshotJPEG silent and toggleconsole from the inspector menu bar; Help → About shows engine label, ImGui version, GPU vendor/device/API strings, and r_imgui/F11 usage hint. Co-authored-by: Tim Fox <timfox@outlook.com>
cursor
Bot
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Security review completed for PR #176.
No medium, high, or critical vulnerabilities were identified in the added/modified code. The new ImGui menu actions dispatch fixed local engine commands (screenshotJPEG silent, toggleconsole, quit) without interpolating user-controlled input, and the About modal renders GPU/version strings through constant format strings. I found no prior unresolved automation review threads to carry forward.
Sent by Cursor Automation: Find vulnerabilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the Vulkan ImGui inspector menu bar for day-to-day debugging.
Changes
screenshotJPEG silent(same as console).toggleconsole.quit(clean exit).Q3_VERSION, Dear ImGui version, Vulkan vs OpenGL label,glConfigvendor/renderer/version strings, and a short note onr_imgui/ F11.Files
src/renderers/vulkan/inspector/vk_imgui.cppCHANGELOG.md([Unreleased] → Added)Validation
./scripts/compile_engine.sh vulkanctest -R smoke_test