Prune stale log files on startup#24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily rolling appender creates one
omnyssh.log.YYYY-MM-DDfile per day in the config directory and never cleans them up, so logs accumulate indefinitely and fill the disk over time.This adds
cleanup_old_logs, which runs once at startup and removes rolling log files older than 7 days. It is:dirs::config_dir()/omnyssh, the same directory used on macOS, Linux, Termux, and Windows. Age is read from filesystem mtime, so the logic is identical everywhere.omnyssh.logare considered;config.toml,hosts.toml, andsnippets.tomlare never touched.Covered by 4 integration tests: old files removed, recent files kept, non-log files untouched, and missing directory is a no-op.