fix(deps): pin versions of all GitHub Actions workflows and NPM packages#73
Merged
fix(deps): pin versions of all GitHub Actions workflows and NPM packages#73
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated CI workflows and package.json to pin tool and dependency versions: Node.js set to 24.13.1, pnpm to 10.30.3 across workflows, semantic-release plugins pinned, and dependencies/devDependencies in package.json changed from ranged to fixed versions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/publish.yml (1)
85-88: Reorder cache restore keys from most-specific to least-specific.The current order checks the broad prefix first, so the lockfile-scoped fallback at Line 88 is rarely used.
Suggested diff
restore-keys: | - ${{ runner.os }}-pnpm- ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}- + ${{ runner.os }}-pnpm-🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/publish.yml around lines 85 - 88, The restore-keys are ordered from least-specific to most-specific so the broad prefix wins and the lockfile-scoped fallback is ignored; inside the cache step adjust the "restore-keys" block so the most-specific key (${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}-node-${{ hashFiles('.nvmrc') }}) appears first, then the lockfile-scoped key (${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}-), and finally the broad prefix (${{ runner.os }}-pnpm-), ensuring the cache lookup goes from most-specific to least-specific.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/publish.yml:
- Around line 85-88: The restore-keys are ordered from least-specific to
most-specific so the broad prefix wins and the lockfile-scoped fallback is
ignored; inside the cache step adjust the "restore-keys" block so the
most-specific key (${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml')
}}-node-${{ hashFiles('.nvmrc') }}) appears first, then the lockfile-scoped key
(${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}-), and finally the
broad prefix (${{ runner.os }}-pnpm-), ensuring the cache lookup goes from
most-specific to least-specific.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
.github/workflows/codeql-analysis.yml.github/workflows/publish.yml.github/workflows/pull-request.yml.github/workflows/release.ymlpackage.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 8 8
Lines 269 269
Branches 101 101
=======================================
Hits 252 252
Misses 1 1
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🩺 React Doctor |
|
🎉 This PR is included in version 1.2.35 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
17 tasks
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to multiple supply-chain attacks by AI bots, this PR adds another layer of security by pinning all dependencies to a specific version and, when possible, to a hash.
Type of change
Checklist
Code quality
feat:,fix:,docs:,chore:)anyTypeScript types without justificationconsole.log, or commented-out blocksTesting
F5in VSCode to launch the Extension Development Hostpnpm test, and all tests passpnpm lint, and there are no lint errorsBuild & compatibility
pnpm run compileandpnpm run webpackwithout errorsDocumentation
README.mdif my change adds a new feature, keyboard shortcut, or changes existing behaviourScreenshots/recordings
Summary by CodeRabbit