#201 initial support for v3 -> v4 api changes. #206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Probably the major version of java-gitlab-api should be increased because this is not backwards compatible. For easier consumption I would suggest to bump the major to 4 to correspond to the gitlab API version. |
This was referenced Apr 24, 2017
Closed
Contributor
|
Based on this branch in #207 I provided at least execution of existing tests in travis |
Owner
|
@mfriedenhagen In terms of order, should I merge this PR before #207? |
Contributor
|
Hello, PR #207 contains the commit from this one, I am not sure whether I would need to rebase afterwards. Anyway, let's just try:-) |
Owner
|
Going to close this PR since I've merged #207. Thank you very much @iwarapter for this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@timols this isnt quite ready yet, however im just putting a docker/travis test harness for this together to get some good functional tests.