feat(workflow): generalize review scripts + fix Claude review posting#1068
Closed
timothyfroehlich wants to merge 2 commits intomainfrom
Closed
feat(workflow): generalize review scripts + fix Claude review posting#1068timothyfroehlich wants to merge 2 commits intomainfrom
timothyfroehlich wants to merge 2 commits intomainfrom
Conversation
Extract hardcoded Copilot bot logins into shared _review-config.sh. All 5 review scripts now source this config and use --argjson bots for jq filtering, so adding a new reviewer is a one-line change. Also adds workflow_dispatch trigger to claude-code-review.yml so reviews can be manually triggered by PR number. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Without explicit github_token, the OAuth-exchanged token replaces GITHUB_TOKEN but lacks pull-requests:write permission, causing Claude to silently fail to post review comments (anthropics/claude-code-action#891). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Updates to Preview Branch (chore/review-workflow-update) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
Owner
Author
|
Splitting: action fix going into a separate minimal PR. Script generalization will come separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr-dashboard.sh,label-ready.sh,copilot-comments.sh,respond-to-copilot.sh,resolve-copilot-threads.sh) to support multiple AI reviewer bots via shared_review-config.shgithub_token(Issue comment workflow: Claude runs but doesn't post comments to issues anthropics/claude-code-action#891)workflow_dispatchtrigger so reviews can be manually triggered by PR numberTest plan
pnpm run checkpasses (715 tests)pr-dashboard.shshows "Review" column with correct countslabel-ready.shcorrectly blocks on unresolved threadscopilot-comments.shdisplays comments with generalized filtergithub_tokenfix on main)🤖 Generated with Claude Code