async loop solution does not pass

[connor11528]

I use your solution code for async-loops but still does not pass. The exercise (run or verify) haaaangs.

code:

function loadUsers(userIds, load, done) {
  var completed = 0
  var users = []
  userIds.forEach(function(id, index) {
    load(id, function(user) {
      console.log(user) // logs out one or two user objects
      users[index] = user
      if (++completed === userIds.length) return done(users)
    })
  })
}

module.exports = loadUsers

not passing for me

[timoxley]

my apologies, I'll look into it asap.

[timoxley]

whoa yeah something is weird with this

[timoxley]

actually, your problem is the console.log in there. Remove it and you should be fine.

[cottyard]

I get the same hanging problem with the solution code(no console.log used). It prints the correct output once in a while and hangs most of the times. My nodejs version is v0.10.30.

[timoxley]

really weird, hm.

[timoxley]

@jasonshark @cottyard nodeschool/discussions#486 (comment)

Fixed in 0.0.27.

[igorbelykh86]

Hello,
I've solved this problem by following way:

function loadUsers(userIds, load, done) {
    var users = {length: 0};
    userIds.forEach(function(val, index) {
        load(val, function(data) {
            users[index] = data;
            if(++users.length == userIds.length) done(Array.prototype.slice.call(users, 0));
        });
    });
}

Why this solution is worse?