Skip to content

fix: respect ZDOTDIR for zsh init#52

Merged
timvw merged 1 commit intotimvw:mainfrom
brosu:fix/wt-init-zshrc-upstream
Feb 27, 2026
Merged

fix: respect ZDOTDIR for zsh init#52
timvw merged 1 commit intotimvw:mainfrom
brosu:fix/wt-init-zshrc-upstream

Conversation

@brosu
Copy link
Contributor

@brosu brosu commented Feb 21, 2026

wt init zsh now updates ${ZDOTDIR:-$HOME}/.zshrc (and activation instructions match), instead of always writing ~/.zshrc.

Tests:

  • go test ./... (includes TestGetShellConfigPathZshRespectsZdotdir and updated TestGetShellConfigPath to be stable when ZDOTDIR is set)

@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.38%. Comparing base (0c58a2c) to head (1ffd3d9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
init.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   27.19%   27.38%   +0.18%     
==========================================
  Files           4        4              
  Lines        1570     1574       +4     
==========================================
+ Hits          427      431       +4     
  Misses       1094     1094              
  Partials       49       49              
Files with missing lines Coverage Δ
init.go 45.06% <33.33%> (+0.12%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@timvw timvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approving and merging.

@timvw
Copy link
Owner

timvw commented Feb 27, 2026

Thanks a lot for the fix and tests, really appreciate it 🙌

@timvw timvw enabled auto-merge (rebase) February 27, 2026 21:24
@timvw timvw force-pushed the fix/wt-init-zshrc-upstream branch from 7bf408e to 1ffd3d9 Compare February 27, 2026 21:27
@timvw timvw merged commit 661d0f9 into timvw:main Feb 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants