Skip to content

3.5.1 Only check for AS3CF remove local setting if plug-in is active#48

Merged
rkoopmans merged 5 commits intotinify:masterfrom
wcreateweb:bug/as3cf-active-nooption
Apr 9, 2025
Merged

3.5.1 Only check for AS3CF remove local setting if plug-in is active#48
rkoopmans merged 5 commits intotinify:masterfrom
wcreateweb:bug/as3cf-active-nooption

Conversation

@tijmenbruggeman
Copy link
Copy Markdown
Collaborator

@tijmenbruggeman tijmenbruggeman commented Apr 8, 2025

A user reported an issue where they would get an error when loading the Tinify settings page. This happened on the check if AS3CF would remove files locally. The request is done on the plug-in settings page to render a warning and only happens if the plug-in AS3CF is active.

Internally get_option would return null. This option should not return null as it contains all the settings for AS3CF. Nonetheless it returned null so there is a case where the user has not set any settings yet but has the plug-in activated.

Therefor I've added a check to see if the get_option returns a valid value.

  • Added a check to verify if the plug-in is active
  • Check if the plug-in option exists
  • Added debug script for unit tests
  • Added unit tests for AS3CF compatibility

@rkoopmans rkoopmans merged commit 22ad777 into tinify:master Apr 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants