3.5.1 Only check for AS3CF remove local setting if plug-in is active#48
Merged
rkoopmans merged 5 commits intotinify:masterfrom Apr 9, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user reported an issue where they would get an error when loading the Tinify settings page. This happened on the check if AS3CF would remove files locally. The request is done on the plug-in settings page to render a warning and only happens if the plug-in AS3CF is active.
Internally
get_optionwould returnnull. This option should not return null as it contains all the settings for AS3CF. Nonetheless it returned null so there is a case where the user has not set any settings yet but has the plug-in activated.Therefor I've added a check to see if the
get_optionreturns a valid value.