[hook-bootkit] Add /dev and /run mounts: #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed so that the Tink agent has access to the Host's disks. Tink agent uses https://github.com/jaypipes/ghw. And in Hook the agent runs in a container and for ghw be able to identify everything about the disk devices these mount points are required. From ghw's README: NOTE: ghw looks in the udev runtime database for some information. If you are using ghw in a container, remember to bind mount /dev/disk and /run into your container, otherwise ghw won't be able to query the udev DB or sysfs paths for information. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
changed the title
jacobweinstock
added
kind/enhancement
ready-to-merge
Contributor
Merge Queue Status✅ The pull request has been merged at 415a727 This pull request spent 8 seconds in the queue, with no time running CI. Required conditions to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is needed so that the Tink agent has access to the Host's disks. Tink agent uses https://github.com/jaypipes/ghw. And in Hook the agent runs in a container and for ghw be able to identify everything about the disk devices these mount points are required.
From ghw's README:
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: